:: Re: [Frei0r] [PATCH] Remove extra i…
Top Page
Delete this message
Reply to this message
Author: salsaman
Date:  
To: Minimalistic plugin API for video effects
Subject: Re: [Frei0r] [PATCH] Remove extra input params from C++ update() methods.
Please check and see if it is a genuine issue.
On Fri, Sep 2, 2016 at 12:13 PM, Jaromil <jaromil@???> wrote:

> On Fri, 02 Sep 2016, salsaman wrote:
>
>
> >    Yes that is the correct script to run ! You will need to load /
> >    reload a couple of clips first before running it.  The script
> >    will run each effect in turn. It will set each parameter in turn
> >    to its min / max / default value.  It reports some errors, such
> >    as the default being outside the min / max values.  Otherwise
> >    look for crashes with gdb (if the crash is in LiVES please report
> >    it ;-) ) It's also possible to check with valgrind to look for
> >    memory leaks.  If somebody can remind me where the latest frei0r
> >    code is these days I will run it myself too.

>
> thanks!
>
> it is here https://github.com/dyne/frei0r
>
> download with git using command:
>
> git clone https://github.com/dyne/frei0r
>
> then `cmake .` and make
>
> the patch is already applied and compiles fine.
>
> would be great if you can run the tests in person since you know best
>
> ciao!!
>
> _______________________________________________
> Frei0r mailing list - http://frei0r.dyne.org
> Free video plugins, minimal and cross-platform.
> https://mailinglists.dyne.org/cgi-bin/mailman/listinfo/frei0r
>




Plugins all run fine (tested on 2 machines). Due to hardware restrictions I
wasn't able to fully run the plugins through valgrind, although I did find
this in the plugin init:

==31973== 1,796,928 bytes in 1 blocks are definitely lost in loss record
31,976 of 31,979
==31973==    at 0x4C2FFC6: memalign (in /usr/lib/valgrind/vgpreload_me
mcheck-amd64-linux.so)
==31973==    by 0x2C39F2E0: gavl_video_frame_create (in
/usr/lib/x86_64-linux-gnu/libgavl.so.1.0.0)
==31973==    by 0x4C22B102: f0r_construct (in /usr/lib/frei0r-1/rgbparade.so
)



If somebody can look into this it would be appreciated. Other than that, I
think it is good to go !