:: [DNG] Edward's Roaming handler: was…
Top Page
Delete this message
Reply to this message
Author: Steve Litt
Date:  
To: dng
Old-Topics: Re: [DNG] Systemd Shims
Subject: [DNG] Edward's Roaming handler: was Systemd Shims
On Wed, 19 Aug 2015 14:29:02 +0100
Edward Bartolo <edbarx@???> wrote:

> This is the completed C backend with all functions tested to work. Any
> suggestions as to modifications are welcome.
>
> The C code:


Hi Edward,

A little low hanging fruit...

I'd change all the strcat() to strncat() for safety. On most of them,
it would just be something like

strncat(dst, src, sizeof(dst)-1);

Within the exec() function, I think you'd need to pass an extra
argument that defines the size of the "out" argument.

SteveT

Steve Litt
August 2015 featured book: Troubleshooting: Just the Facts
http://www.troubleshooters.com/tjust