Re: [maemo-leste] [PATCH] power: supply: bq27xxx_battery: do not update cached flags prematurely

Author: Pali Rohár
Date:
To: Sicelo A. Mhlongo
CC: Krzysztof Kozlowski, linux-pm, sre, linux-kernel, maemo-leste
Subject: Re: [maemo-leste] [PATCH] power: supply: bq27xxx_battery: do not update cached flags prematurely

cc Krzysztof, author of the mentioned commit.

On Monday 25 November 2024 17:29:30 Sicelo A. Mhlongo wrote:
> Commit 243f8ffc883a1 ("power: supply: bq27xxx_battery: Notify also about
> status changes") intended to notify userspace when the status changes,
> based on the flags register. However, the cached state is updated too
> early, before the flags are tested for any changes. Remove the premature
> update.
>
> Fixes: 243f8ffc883a1 ("power: supply: bq27xxx_battery: Notify also about status changes")
> Signed-off-by: Sicelo A. Mhlongo <absicsz@???>
> ---
> drivers/power/supply/bq27xxx_battery.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c > index 40c5ac7a1118..b2c65fe43d5c 100644 > --- a/drivers/power/supply/bq27xxx_battery.c > +++ b/drivers/power/supply/bq27xxx_battery.c > @@ -1913,7 +1913,6 @@ static void bq27xxx_battery_update_unlocked(struct bq27xxx_device_info *di) > cache.flags = -1; /* read error */ > if (cache.flags >= 0) { > cache.capacity = bq27xxx_battery_read_soc(di); > - di->cache.flags = cache.flags;

>
> /* > * On gauges with signed current reporting the current must be > -- > 2.45.2

>

This message is part of the following thread:
	the complete thread tree sorted by date
	Sicelo A. Mhlongo at

Donate to Dyne.org