:: [maemo-leste] [PATCH 3/6] Nokia RX-…
Top Page
Delete this message
Reply to this message
Author: Pali Rohár
To: u-boot, maemo-leste, Ivaylo Dimitrov, Lokesh Vutla, Tom Rini
CC: Faiz Abbas, Peng Fan, Heiko Schocher, Adam Ford, Anatolij Gustschin, Simon Glass
Old-Topics: [maemo-leste] [PATCH 1/6] Nokia RX-51: Remove old comments from configs/nokia_rx51.h file
Subject: [maemo-leste] [PATCH 3/6] Nokia RX-51: During init disable lp5523 led instead of resetting it
After commit d5243359e1af ("OMAP24xx I2C: Add support for set-speed")
U-Boot is unstable to reset lp5523 led. That commit added pooling for i2c
poll ARDY bit which apparently is never set. It is not known what is
happening here.

Purpose of resetting lp5523 led in Nokia RX-51 code is just to turn off
very bright led which is powered on by NOLO and expects next boot image
(kernel or U-Boot) to turn it off.

After testing we observed that just disabling lp5523 led is working fine.

So as a workaround to this ARDY bit i2c issue we disable lp5523 led instead
of resetting it.

Signed-off-by: Pali Rohár <pali@???>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@???>
board/nokia/rx51/rx51.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/nokia/rx51/rx51.c b/board/nokia/rx51/rx51.c
index e11c527226..528c592441 100644
--- a/board/nokia/rx51/rx51.c
+++ b/board/nokia/rx51/rx51.c
@@ -394,9 +394,9 @@ int misc_init_r(void)
     char buf[12];
     u8 state;

-    /* reset lp5523 led */
+    /* disable lp5523 led */
     if (i2c_get_chip_for_busnum(1, 0x32, 1, &dev) == 0)
-        dm_i2c_reg_write(dev, 0x3d, 0xff);
+        dm_i2c_reg_write(dev, 0x00, 0x00);

     /* initialize twl4030 power managment */