:: Re: [maemo-leste] Droid 4 in 5.3-rc…
Top Page
Delete this message
Reply to this message
Author: Pavel Machek
Date:  
To: Tony Lindgren
CC: Merlijn Wajer, maemo-leste, Ivaylo Dimitrov, Sebastian Reichel
Subject: Re: [maemo-leste] Droid 4 in 5.3-rc1, development boards
Hi!

> > >> On 13/07/2019 21:47, Pavel Machek wrote:
> > >>> 5.3-rc1 should be released next week, and it should be interesting
> > >>> release for Droid 4. AFAICT it should be possible to get video to work
> > >>> there with minimal changes.
> > >>
> > >> Great. Our current Droid4 kernels are based on branches prepared by
> > >> Tony. If we can follow mainline without patches, that would ultimately
> > >> be better.
> > >
> > > Yeah I'll do v5.2 based branch with the dss backported and with the
> > > pending modem stuff. I'll be also working more on getting the n_gsm
> > > modem support upstreamed, I think that's now the only set of pending
> > > patches :)
> >
> > Cool, please let me know when you've done that. I'd be glad to get it in
> > our repo.
>
> OK just pushed out droid4-pending-v5.2 with all the drm stuff for v5.3
> merged and the same old pending mdm patches merged in. Also included
> is the usb option config and the serdev PM issue I noticed with no
> serdev drivers loaded.


Thanks, I'm taking a look.

> # ofono needs these
> KERNEL=="ttyUSB4", ENV{OFONO_DRIVER}="g1"


This line is probably bad idea. I was using it to get hacked ofonod to
work, but you probably don't need it.

> Oh and the new backlight module comes up blanked right now so it
> needs to be manually enabled via sysfs.


Or you can enable ledtrig-backlight and apply this.

(I know, we need better solution).

Best regards,
                                Pavel


diff --git a/drivers/leds/trigger/ledtrig-backlight.c b/drivers/leds/trigger/ledtrig-backlight.c
index 487577d..6e6bc78 100644
--- a/drivers/leds/trigger/ledtrig-backlight.c
+++ b/drivers/leds/trigger/ledtrig-backlight.c
@@ -114,6 +114,8 @@ static int bl_trig_activate(struct led_classdev *led)
     n->old_status = UNBLANK;
     n->notifier.notifier_call = fb_notifier_callback;


+    led_set_brightness(led, LED_ON);
+
     ret = fb_register_client(&n->notifier);
     if (ret)
         dev_err(led->dev, "unable to register backlight trigger\n");
@@ -126,6 +128,7 @@ static void bl_trig_deactivate(struct led_classdev *led)
     struct bl_trig_notifier *n = led_get_trigger_data(led);


     fb_unregister_client(&n->notifier);
+    led_set_brightness(led, LED_OFF);
     kfree(n);
 }


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html