A had a quick look, seems like a lot of it is useful and fixes some minor
bugs. A question, here for example:

@@ -164,8 +164,10 @@ void f0r_update(f0r_instance_t instance, double time,

// Create brightness image
unsigned int len = inst->width * inst->height;
- unsigned char bumpPixels[len];
- unsigned char alphaVals[len];
+ unsigned char *bumpPixels;
+ unsigned char *alphaVals;
+ bumpPixels = (unsigned char *) calloc(len, sizeof(unsigned char));
+ alphaVals = (unsigned char *) calloc(len, sizeof(unsigned char));


Is there a corresponding free() for these heap allocations ?






http://lives.sourceforge.net
https://www.openhub.net/accounts/salsaman

On Sun, Dec 15, 2013 at 4:23 PM, Dan Dennedy <dan@???> wrote:

> Wrong mailing list.
>
> On Sat, Dec 14, 2013 at 3:07 PM, Andrius da Costa Ribas
> <andriusmao@???> wrote:
> > Hello,
> >
> > I'm new to this mailing list. I'm trying to build Kdenlive, and as
> Frei0r is
> > one of its dependencies, I've tried to build it too, however I needed
> some
> > adjustments to make it work with MSVC. Would you please review the
> attached
> > patch and commit if it is okay?
>
> I don't have a problem with the allocation casts.
>
> I am not happy with the asm for the rounding functions. I do not know
> if they are equivalent enough. What happens when there is a bug report
> about them? Do the reporters and reporters have to figure out what the
> asm does? Are they based on code from another project that can give us
> more confidence about them?
>
> Perhaps any supplemental math functions and constants (M_PI) belong in
> frei0r_math.h or include/msvc/frei0r_math.h and not sprinkled
> throughout the code.
>
> Regarding M_PI, I see in partik0l.cpp:
>
> #if defined(_MSC_VER)
> #define _USE_MATH_DEFINES
> #endif /* _MSC_VER */
>
> In some functions (for ex, dither.c:f0r_update()) you changed arrays
> on the stack to the heap, but the mem is not freed. Please look for
> those and fix them.
>
> > Cheers,
> > Andrius.
> >
> > _______________________________________________
> > frei0r-devel mailing list
> > frei0r-devel@???
> > http://piksel.no/cgi-bin/mailman/listinfo/frei0r-devel
> >
>
> --
> +-DRD-+
>
> _______________________________________________
> Frei0r mailing list - http://frei0r.dyne.org
> Free video plugins, minimal and cross-platform.
> https://mailinglists.dyne.org/cgi-bin/mailman/listinfo/frei0r
>
>