:: Re: [Frei0r] "softglow" plugin
Top Page
This message is part of the following thread:
M--\the complete thread tree sorted by date
M-\MJanne Liljeblad at <-
M\MJanne Liljeblad at ->
Delete this message
Reply to this message
Author: Dan Dennedy
Date:  
To: Minimalistic plugin API for video effects
Subject: Re: [Frei0r] "softglow" plugin
On Mon, Oct 15, 2012 at 12:32 AM, Janne Liljeblad
<janne.liljeblad@???> wrote:
>> +++ b/src/filter/softglow/blur.h
>> @@ -0,0 +1,291 @@
>> +/* squareblur.c
>> + * Copyright (C) 2004--2005 Mathieu Guindon
>> + *                          Julien Keable
>> + *                          Jean-Sebastien Senecal (js@???)

>>
>> I see you copied this from src/filter/mask0mate, and it is also used
>> in src/filter/glow/. Should we perpetuate this madness or put blur.h
>> into include/ or refactor all of these to use a common blur.o?
>
> It is starting to get a bit silly, yes. I think putting blur.h into
> include/ would be appropriate here. If we agree on this, I'll can send
> you patch that does that.

I moved blur.h into include and pushed all of your patches.

--
+-DRD-+

This message was posted to the following mailing lists:
frei0r
Mailing List Info | Nearby Messages		<-Re: [Frei0r] "softglow" pluginRe: [Frei0r] autoconf build problems and switch to cmake only->

Donate to Dyne.org

dyne.org open discussions
administrated by dyne.org hackers		Lurker (version 2.3)