Hi,
On Thu, Nov 28, 2024 at 10:57:27AM +0200, Sicelo A. Mhlongo wrote:
> bq2415x_notifier_call is called asynchronously, when a change is notified
> from the external notify device. Therefore, reschedule the work item to
> run as soon as possible thereafter.
>
> Suggested-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@???>
> Signed-off-by: Sicelo A. Mhlongo <absicsz@???>
> ---
The commit message reads quite weird, but the code change makes
sense to me. I think something like this commit message makes
more sense:
When the notifier is called we want to schedule the worker as
soon as possible. Thus it makes sense to reschedule any waiting
work and only queue a new one if there is none.
Greetings,
-- Sebastian
> drivers/power/supply/bq2415x_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c
> index 25e28dac900d..1a02195769a3 100644
> --- a/drivers/power/supply/bq2415x_charger.c
> +++ b/drivers/power/supply/bq2415x_charger.c
> @@ -839,7 +839,7 @@ static int bq2415x_notifier_call(struct notifier_block *nb,
> if (bq->automode < 1)
> return NOTIFY_OK;
>
> - schedule_delayed_work(&bq->work, 0);
> + mod_delayed_work(system_wq, &bq->work, 0);
>
> return NOTIFY_OK;
> }
> --
> 2.45.2
>
>
::
Re: [maemo-leste] [PATCH 1/2] power…
