:: Re: [devuan-dev] Status of the SLiM…
Αρχική Σελίδα
Delete this message
Reply to this message
Συντάκτης: Boian Bonev
Ημερομηνία:  
Προς: devuan developers internal list
Αντικείμενο: Re: [devuan-dev] Status of the SLiM login manager project
Hi Rob,

> I've downloaded your commits and tried again (after rebooting the VM)
> and I don't get errors, just the attached warnings. I see you've
> removed the upstart file, so that was presumably the only error I'd
> been seeing (though it was fatal so I couldn't be sure until that was
> resolved).
>
> Strangely, I now get three "patch-not-forwarded-upstream" warnings,
> which I hadn't previously been getting. Possibly that's a compat rule
> change, as they are the ones that have a Debian reference.


Just annotate them as

Forwarded: not-needed
or
Forwarded: yes

depending on their forwarded to upstream status.

> You will note that one of the overrides you removed as redundant is
> still needed when I build it, as the false positive is being
> triggered.


OK, now I see one of the reasons for the different results - you do not
have devuan-lintian-profile installed. If I remove it, I also get the
same result as you.

Mark, I can not see the reason why the spelling-error-in-binary is
masked by the Devuan's lintian profile - do you have an idea?

I think that slim does not need the large file support, so binary-file-
built-without-LFS-support can be safely ignored. It does not need an
override, because it is not a warning.

> P.S. I'm still learning my way round git/gitea and haven't figured
> out how to properly "cherry pick" your changes into my repo.


I will make a pull request now, hope that will make things easier. Then
you can just revert the commits that you do not like.

About the next steps:

If you plan to maintain slim for Devuan, set Maintainer: to yourself
and remove Uploaders:

Alternatively if you prefer to keep it as a team effort, just add
yourself to Uploaders; in both cases the 'Non maintainer upload' log
entry is bogus (I removed it).

When all this is done, someone from the team will add you to the
devuan/slim project and you can merge the changes and trigger builds.

With best regards,
b.