Adam,

On Sun, Dec 18, 2022 at 05:57:25PM +0000, Adam Sampson wrote:
> Hi Mark,
>
> On Tue, Dec 13, 2022 at 06:49:46PM +0000, Mark Hindley wrote:
> > rrq and I have been looking at the possibility of patching the xorg
> > server to use libseat[1] (and therefore either seatd itself or logind)
> > for providing management of video and input resources for rootless
> > startx.
>
> Thanks very much for implementing this -- it's something I'd been
> wondering about as well. I've given it some testing on my (non-Devuan
> but Linux) systems and it all appears to behave correctly under seatd,
> including VT switches and hotplugging input devices. Nice!

Thanks, that is good to know.

> On the assumption that you plan to submit this for upstream review at
> some point, I've attached some patches to bring it closer to the xserver
> style guidelines, which you should be able to squash into your existing
> patch. This is mostly updating spacing/comment styles, but there's one
> minor change to get rid of a VLA in the code.

I have been cleaning up and reducing the diff with upstream as well and have
most of your suggestions already. I'll look through the rest.

> I wonder if it would be worth renaming the configure option and
> functions to just "libseat" rather than "seatd-libseat" -- in theory
> you should be able to use logind/elogind through libseat as well...

Yes, the name came by analogy to the systemd-logind option. I think that will
ultimately be a question for upstream.

I'll merge and then my plan is to ask the seatd/libseat developers for comments.

Many thanks.

Mark