:: Re: [maemo-leste] [PATCH 02/14] vid…
Forside
Slet denne besked
Besvar denne besked
Skribent: Pali Rohár
Dato:  
Til: Simon Glass
CC: Merlijn Wajer, maemo-leste, Ivaylo Dimitrov, U-Boot Mailing List, Anatolij Gustschin, Jagan Teki, Andre Przywara
Emne: Re: [maemo-leste] [PATCH 02/14] video: nokia_rx51: Drop obsolete video code
On Sunday 23 January 2022 07:36:22 Simon Glass wrote:
> Hi Pali,
>
> On Sun, 23 Jan 2022 at 07:08, Pali Rohár <pali@???> wrote:
> >
> > + Maemo
> >
> > On Sunday 23 January 2022 07:04:03 Simon Glass wrote:
> > > Drop this code which uses a header that is about to be deleted.
> >
> > And what / where is the replacement?
>
> This is DM_VIDEO. There are quite a few example drivers in
> drivers/video - perhaps the mxsfb.c one is a reasonable example. See
> the top of video_uclass.c for how frame-buffer allocation works.


I have already WIP patches for usage of video-uclass.c but because
reviewing of N900 patches is slow, I have not sent them yet.

So could you please do NOT remove N900 support? I would really
appreciative for reviewing pending patches instead of sending patches
with board removal.

Note that there is some issue with video_post_bind(), it throws
false-positive error "Video device '%s' cannot allocate frame buffer
memory" with "return -ENOSPC". If I remove that "return -ENOSPC" it is
working fine.