:: Re: [maemo-leste] [PATCH] Nokia RX-…
Forside
Slet denne besked
Besvar denne besked
Skribent: Pali Rohár
Dato:  
Til: Lokesh Vutla
CC: Tom Rini, u-boot, maemo-leste
Emne: Re: [maemo-leste] [PATCH] Nokia RX-51: Decrease i2c speed to 100000
On Tuesday 05 January 2021 11:51:20 Lokesh Vutla wrote:
> On 22/11/20 4:00 am, Pali Rohár wrote:
> > It looks like that i2c bus lot of times timeout on some units. Prior
> > migration to CONFIG_DM_I2C i2c speed was set to CONFIG_SYS_OMAP24_I2C_SPEED
> > value which was 100000. Lower speed fixes timeout problems, so change speed
> > back to its previous value.
> >
> > Signed-off-by: Pali Rohár <pali@???>
> > Fixes: 8d8c18170325 ("Nokia RX-51: Convert to CONFIG_DM_I2C")
>
> Applied to u-boot-ti/for-next branch
>
> Thanks and regards,
> Lokesh
>
> > ---
> > Please include this patch into U-Boot master branch for 2020.01 release
> > to have i2c bus working.


Could you please include this patch into master branch (and not only
into for-next) as I asked more than month ago? It is fixing i2c bus.

> > ---
> > board/nokia/rx51/rx51.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/board/nokia/rx51/rx51.c b/board/nokia/rx51/rx51.c
> > index 3d62b5d9ad..2dd41604c9 100644
> > --- a/board/nokia/rx51/rx51.c
> > +++ b/board/nokia/rx51/rx51.c
> > @@ -704,9 +704,9 @@ void board_mmc_power_init(void)
> > }
> >
> >  static const struct omap_i2c_platdata rx51_i2c[] = {
> > -    { I2C_BASE1, 2200000, OMAP_I2C_REV_V1 },
> > +    { I2C_BASE1, 100000, OMAP_I2C_REV_V1 },
> >      { I2C_BASE2, 100000, OMAP_I2C_REV_V1 },
> > -    { I2C_BASE3, 400000, OMAP_I2C_REV_V1 },
> > +    { I2C_BASE3, 100000, OMAP_I2C_REV_V1 },
> >  };

> >
> > U_BOOT_DEVICES(rx51_i2c) = {
> >