:: Re: [maemo-leste] merging ofono ver…
Página Inicial
Delete this message
Reply to this message
Autor: Tony Lindgren
Data:  
Para: Pavel Machek
CC: Merlijn Wajer, maemo-leste, nekit1000, mpartap, sre, martin_rysavy
Assunto: Re: [maemo-leste] merging ofono versions was Re: Grand plan to get make phones... phone (for Motorola Droid 4)
* Pavel Machek <pavel@???> [200610 20:48]:
> Umm. Lets see. motchat can be simplified a bit more, but not that
> much, AFAICT.


Yeah. Let's also look at what mbimmodem is doing for
reads and writes.

> I pushed new version to github:
>
> To github.com:pavelmachek/ofono.git
>    ad902164..692495b0  tony-v1.31-1 -> tony-v1.31-1

>
> Could you take a look? AFAICT sms acknowledging does not work, but it
> did not work for me in your versions, either, that's why I did this.


Weird. I wonder what's up with that? I noticed that ack does
not always respond and added the AT+GCNMA=? query to produce
a response first befor ack in commit 7d9b996c365. That seemed
to solve the acking sometimes not working issue for me.

> For a start, could I get you to (review and) cherry-pick:
>
> c882e0978dd471c17d8f4daa3373e42326713b12
>     cleanup: +CREG has nothing to do with PDU, AFAICT.


Yeah OK that looks like a typo for CREG. For incoming SMS,
they really seem like proper PDUs though. Except some firmware
terminate them with '\n' instead of '\r'.. And I think we only
ever get one sms at a time, not a list. Well so far I've not
seen a PDU list.

But hey if it works without treating it as a PDU fine with
me.

> 299a18979a49d7b0fd852a1b652564bedc7908e7
>     cleanup: USB_AT interface should no longer be needed.


Yeah agreed. If we ever need the /dev/ttyUSB* devices,
it will be for the qcdm interface.

> 7e7b2afb19976c7f83b1ce7a982c53bc4a55712f
>     d4: Document protocol a bit.


Yup I agree with that one for sure :)

Tony