:: Re: [maemo-leste] N900 camera suppo…
Top Pagina
Delete this message
Reply to this message
Auteur: Pavel Machek
Datum:  
Aan: Merlijn Wajer
CC: maemo-leste
Onderwerp: Re: [maemo-leste] N900 camera support was Re: Droid 4, camera support, notifications
Hi!

> > > Camera support may not be as simple as you think; getting blurry
> > > useless pictures is easy, getting reasonable pictures is pretty hard.
> > > I actually did whole talk about that
> > > https://www.youtube.com/watch?v=fH6zuK2OOVU .
> >
> > Understood, and yeah, that's certainly true. Right now, I will be happy
> > without camera support for a while, if the other parts start to work.
>
> Yes, there are more important parts.
>
> I tried to build by camera support code, but that really needs
> libsdl2-dev, and that one really does not want to cooperate; it wants to
> uninstall hildon-meta-n900 ti-omap3-sgx when I attempt to install
> it.


For camera, I need this patch, otherwise image is deformed (square
instead of proper shape). Unfortunately, I don't have good idea why
that's the case.

Could we still get it applied to N900 tree?

Best regards,

                                Pavel

                                
commit a7dbd981de7d7428f7618f34abea2c5c1e831b5c
Author: Pavel <pavel@???>
Date: Sun Oct 28 13:19:33 2018 +0100

    n900: camera: magic bit makes it work.


diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c
index 471ae7cdb813..d88feba41bcd 100644
--- a/drivers/media/platform/omap3isp/ispccdc.c
+++ b/drivers/media/platform/omap3isp/ispccdc.c
@@ -1179,7 +1179,8 @@ static void ccdc_configure(struct isp_ccdc_device *ccdc)
     /* Use the raw, unprocessed data when writing to memory. The H3A and
      * histogram modules are still fed with lens shading corrected data.
      */
-    syn_mode &= ~ISPCCDC_SYN_MODE_VP2SDR;
+//    syn_mode &= ~ISPCCDC_SYN_MODE_VP2SDR;
+    syn_mode |= ISPCCDC_SYN_MODE_VP2SDR;


     if (ccdc->output & CCDC_OUTPUT_MEMORY)
         syn_mode |= ISPCCDC_SYN_MODE_WEN;


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html