:: Re: [devuan-dev] [amprolla3] patche…
Page principale
Supprimer ce message
Répondre à ce message
Auteur: Joril
Date:  
À: devuan developers internal list
Sujet: Re: [devuan-dev] [amprolla3] patches to fix locking
On Sat, 14 Sep 2019 17:18:03 +0200
Evilham <devuan@???> wrote:

> Hello,
>
> due to the way file systems work, merely using the existence of a
> file as a lock is not robust as has been observed.
>
> Please make the time to review a patch for amprolla3 that makes
> sure only one amprolla-related operation is running at any given
> time and does not have lingering-lock-file-breaks-everything as an
> issue.
> man 2 flock explains this in better detail than I could.
>
> The patch itself:
> https://git.devuan.org/devuan-infrastructure/amprolla3/merge_requests/2


Hello,

sadly I'm not familiar with Amprolla's logic so I can't comment on orchestrate.sh, but the patch on the Python side looks good to me too :)

Bye!