:: Re: [Frei0r] [dyne/frei0r] Fix libm…
Inizio della pagina
Delete this message
Reply to this message
Autore: Jean-Baptiste Mardelle
Data:  
To: reply+0001a6dc24015ba5a428a4f6a14882ae491b7a66dbc3dc9792cf0000000113e6b45692a169ce0a71201e
CC: frei0r
Oggetto: Re: [Frei0r] [dyne/frei0r] Fix libmath linking crashes (#3)
On Tuesday, September 6, 2016 6:44:06 PM CEST, Dan Dennedy wrote:
> I think if we do this we should add linker option --as-needed.


I can confirm that some plugins still crash because of underlinking on
Ubuntu 16.04 with current CMake setup:

melt video.mp4 -attach frei0r.levels
crashes with:
melt: symbol lookup error: /usr/local/lib/frei0r-1/levels.so: undefined
symbol: pow

This is fixed by my proposal. Also, adding an "--as-needed" flag works for
me:

set (CMAKE_SHARED_LINKER_FLAGS "-Wl,--as-needed")


For the record, the issue was raised in april on this list:

Crash in levels effect:
https://lists.dyne.org/lurker/message/20160404.172311.5230d84e.en.html

Jaromil's answer:
https://lists.dyne.org/lurker/message/20160404.224852.3ba18a57.en.html

Regards
jb