On Sun, Apr 3, 2016 at 3:54 AM, Dan Dennedy <dan@???> wrote:

> The spec concerns the C API, which is not changed by this commit. This is
> a change to C++ method signatures for internal use by the C++ plugins.
> frei0r.hpp is not even installed. You are raising an alarm and stink about
> nothing in my opinion. The change is akin to a bug fix from my perspective
> since the C++ plugins were needlessly storing state making them unsuitable
> for fame-parallel multithreading.
>

You are entitled to your opinion, however you single handledly made a
change to every plugin, and yet did not mention a word about it on the
mailing list. It would have been nice to have discussed it first. If it
fixes an issue then perhaps there would have been alternate / better ways
to do it. Even if not it would have been a courtesy to mention it.



> And no plugins were converted to mixer3 in the process. Maybe you need to
> brush up on your C++.
>
>

I noticed that you added 3 frame inputs to each plugin, even those which
are simple filter effects. I fail to see the reason for this.

Now you defend your actions by questioning my coding abilities ? Very nice.




> Also, there is no documentation update needed as far as the current scope
> of the documentation is concerned.
>
> Remind me of your contribution to this project again? I mean, besides
> reporting some bugs for other people to fix.
>
>
I shouldn't need to remind you but I was active in developing the original
frei0r spec, in addition to contributing to bug testing, creating automated
testing tools, publicising and providing feedback. However that is
irrelevant to the current discussion and for a second time you defend your
actions with a personal attack.


Regards.