Fix submitted here:https://github.com/ddennedy/frei0r/pull/6
~BM

      From: salsaman <salsaman@???>
 To: Brian Matherly <pez4brian@???> 
Cc: Minimalistic plugin API for video effects <frei0r@???>
 Sent: Tuesday, March 15, 2016 8:32 PM
 Subject: Re: [Frei0r] Release ?

Ah. makes sense:

void GradientLut::setDepth(size_t depth) {
    lut.resize(depth);
}

lust.size gets set to zero, then in operator[]:


    if(index >= size) {
        index = size - 1;
    }


index gets set to -1.








http://lives-video.com
https://www.openhub.net/accounts/salsaman

On Tue, Mar 15, 2016 at 10:30 PM, salsaman <salsaman@???> wrote:

It seems to crash when "levels" is set to zero.





http://lives-video.com
https://www.openhub.net/accounts/salsaman

On Tue, Mar 15, 2016 at 10:08 PM, Brian Matherly <pez4brian@???> wrote:

It isn't an array. It's an operator[] on the GradientLut class.
/**
 * Get a color value for a given position in the table.
 * The index in the table will be calculated proportionally to the depth of the
 * LUT.
 */
const GradientLut::Color& GradientLut::operator[](double pos) const {
    unsigned int size = lut.size();
    unsigned int index = (double)size * pos;
    if(index >= size) {
        index = size - 1;
    }
    return lut[index];
};
There is range protection right before the array is indexed.

~BM

      From: salsaman <salsaman@???>
 To: Brian Matherly <pez4brian@???>; Minimalistic plugin API for video effects <frei0r@???> 
 Sent: Tuesday, March 15, 2016 7:54 PM
 Subject: Re: [Frei0r] Release ?

inline void Ndvi::setColor(uint8_t *sample, double index)
{
    double pos = N2P(index);
    const GradientLut::Color& falseColor = gradient[pos];



I don't think using a double as an array index is a very good idea.


Regards,
Salsaman.





http://lives-video.com
https://www.openhub.net/accounts/salsaman

On Tue, Mar 15, 2016 at 9:46 PM, Brian Matherly <pez4brian@???> wrote:

I'm willing to look at it.

The only way I can see that this would happen is if the output image pointer is corrupted.
Can you provide steps to reproduce?
~Brian

      From: salsaman <salsaman@???>
 To: Minimalistic plugin API for video effects <frei0r@???> 
 Sent: Tuesday, March 15, 2016 7:03 PM
 Subject: Re: [Frei0r] Release ?

OK, just one bug found:

Program received signal SIGSEGV, Segmentation fault.

Ndvi::setColor (index=<optimized out>, sample=0x3cc4270 "", this=0x38a3e70) at filter/ndvi/ndvi.cpp:236
236        sample[0] = falseColor.r;



Somebody should fix that before the release.




Regards,
Salsaman.








http://lives-video.com
https://www.openhub.net/accounts/salsaman

On Tue, Mar 15, 2016 at 7:23 PM, Dan Dennedy <dan@???> wrote:

On Tue, Mar 15, 2016 at 3:20 PM salsaman <salsaman@???> wrote:

Alright then, just give me a couple of days to check the git master.



I think that is fine. I will plan to bump version and make dist tarball on the weekend. 
Regards,
Salsaman.


http://lives-video.com
https://www.openhub.net/accounts/salsaman

On Tue, Mar 15, 2016 at 7:14 PM, Dan Dennedy <dan@???> wrote:

On Tue, Mar 15, 2016 at 2:24 PM salsaman <salsaman@???> wrote:

Can you let us test the build before releasing it.



No, sorry. It has already been tested some by apps such as Shotcut that use the git master. That is all the testing I volunteer to do. If you wanted it tested, you should have been doing that. It is past due for a release.
 
Salsaman.



http://lives-video.com
https://www.openhub.net/accounts/salsaman

On Tue, Mar 15, 2016 at 5:18 PM, Dan Dennedy <dan@???> wrote:

On Tue, Mar 15, 2016 at 1:37 AM jb <jb@???> wrote:

Le 27.02.16 09:52, Jb a écrit :
> Hi all,
>
> Would it be possible to get a new frei0r release? There were several
> fixes in the recent months, and the cairo mixers transparency issue,
> that was fixed by Dan in november hits many Kdenlive users.
>
> A release would really help to spread an updated frei0r to end users.

Ping... is anyone still active in the frei0r maintainers team ? We have
a Kdenlive release in april and it would have been really nice to have a
coordinated frei0r release.




Jaromil maintains the web server and has been release manager. I just emailed him, and he responded, but he has not been monitoring the mailing list. I am going to make the release and send it to him, and he will host it.






_______________________________________________
Frei0r mailing list - http://frei0r.dyne.org
Free video plugins, minimal and cross-platform.
https://mailinglists.dyne.org/cgi-bin/mailman/listinfo/frei0r




_______________________________________________
Frei0r mailing list - http://frei0r.dyne.org
Free video plugins, minimal and cross-platform.
https://mailinglists.dyne.org/cgi-bin/mailman/listinfo/frei0r



_______________________________________________
Frei0r mailing list - http://frei0r.dyne.org
Free video plugins, minimal and cross-platform.
https://mailinglists.dyne.org/cgi-bin/mailman/listinfo/frei0r