On Thu, Jan 21, 2016 at 10:02:43PM +0000, Rainer Weikusat wrote:

[cut]

> update-boot(){
>     if [ -n $1 ]; then
>         case $1 in
>             commented)
>                 echo -e "\n$DEF_GRUB_COMMENT\n# $DEF_GRUB_SETTING" >> $DEFAULT_GRUB
>                 return
>                 ;;
>             *)
>                 echo -e "\n$DEF_GRUB_COMMENT\n$DEF_GRUB_SETTING" >> $DEFAULT_GRUB
>                 ;;
>         esac
>     fi     

>

Hi,

I haven't read your code, so my comment might be just silly/irrelevant
here, but it is always safer to use ${DEF_GRUB_COMMENT} instead of
$DEF_GRUB_COMMENT (et similia), especially if the variables are used
in strings, or contatenated to strings...

My2Cents

KatolaZ

--
[ Enzo Nicosia aka KatolaZ --- GLUG Catania -- Freaknet Medialab ]
[ me [at] katolaz.homeunix.net -- http://katolaz.homeunix.net -- ]
[ GNU/Linux User:#325780/ICQ UIN: #258332181/GPG key ID 0B5F062F ]
[ Fingerprint: 8E59 D6AA 445E FDB4 A153 3D5A 5F20 B3AE 0B5F 062F ]