On Sat, Feb 14, 2015 at 4:45 PM, Jaromil <jaromil@???> wrote:
>
> hi Salsaman,
>
> On Fri, 23 Jan 2015, salsaman wrote:
>
> > A had a quick look, seems like a lot of it is useful and fixes some
> > minor bugs.
>
> true. I wonder if Dan has time to look at this.
>
No, sorry.
>
> It is an old patch that was never merged.
>
> > A question, here for example:
> >
> > @@ -164,8 +164,10 @@ void f0r_update(f0r_instance_t instance, double
> time,
> >
> > // Create brightness image
> > unsigned int len = inst->width * inst->height;
> > - unsigned char bumpPixels[len];
> > - unsigned char alphaVals[len];
> > + unsigned char *bumpPixels;
> > + unsigned char *alphaVals;
> > + bumpPixels = (unsigned char *) calloc(len, sizeof(unsigned char));
> > + alphaVals = (unsigned char *) calloc(len, sizeof(unsigned char));
> >
> > Is there a corresponding free() for these heap allocations ?
>
>
> looks like not.
> so perhaps the patch is not so reliable and we should do some testing
> first.
>
> meanwhile I'm wondering about releasing a 1.5: almost two years passed
> since the last release and there were some stability fixes in the
> meantime.
>
>
Sounds good to me. Distro package users will be happier.
--
+-DRD-+
::
Re: [Frei0r] [frei0r-devel] [PATCH]…
