hi Salsaman,

On Fri, 23 Jan 2015, salsaman wrote:

>    A had a quick look, seems like a lot of it is useful and fixes some
>    minor bugs.

true. I wonder if Dan has time to look at this.

It is an old patch that was never merged.

>    A question, here for example:

>
> @@ -164,8 +164,10 @@ void f0r_update(f0r_instance_t instance, double time,
>

>     // Create brightness image
>     unsigned int len = inst->width * inst->height;
>  -  unsigned char bumpPixels[len];
>  -  unsigned char alphaVals[len];
>  +  unsigned char *bumpPixels;
>  +  unsigned char *alphaVals;
>  +  bumpPixels = (unsigned char *) calloc(len, sizeof(unsigned char));
>  +  alphaVals = (unsigned char *) calloc(len, sizeof(unsigned char));

>

>    Is there a corresponding free() for these heap allocations ?

looks like not.
so perhaps the patch is not so reliable and we should do some testing
first.

meanwhile I'm wondering about releasing a 1.5: almost two years passed
since the last release and there were some stability fixes in the
meantime.

ciao


--
Jaromil, Dyne.org Free Software Foundry (est. 2000)
We are free to share code and we code to share freedom
Web: https://j.dyne.org Contact: https://j.dyne.org/c.vcf
GPG: 6113 D89C A825 C5CE DD02 C872 73B3 5DA5 4ACB 7D10
Confidential communications: https://keybase.io/jaromil