Συντάκτης: William Swanson Ημερομηνία: Προς: Eric Voskuil Υ/ο: libbitcoin@lists.dyne.org Αντικείμενο: Re: [Libbitcoin] Library Update
While that's a valid concern, I don't think it will be much of a
problem in practice. For the most part, we will break these names with
"::" or "/", as in "bc::client" or "#include <bitcoin/client>". I
can't think of a reason the full library name would show up in C++
code. Still, I will wait to hear from Amir as well.
-William
On Mon, Sep 8, 2014 at 1:02 AM, Eric Voskuil <eric@???> wrote: > Thanks for the feedback William, it was kinda quiet. I was wondering if the mail didn't go out :).
>
> WRT _/- I'm happy to make the change, I don't have a preference. Amir selected the convention based on a desire to model the boost naming conventions. I suspect the reason them use the underscore vs. the hyphen is that the hyphen is not a valid character in C++. As a result file names cannot match class names (etc.) and it can make searching and refactoring more difficult. I ran into this in the SX rework as the file names match the command names, which use hyphens, but the class names that map to files and commands must differ. I left the command and file names hyphenated because for the commandline it is certainly more conventional.
>
> Since it was his call originally and he put it in the roadmap we should let Amir weigh in on it before changing.