:: Re: [Libbitcoin] Library Update
Góra strony
Delete this message
Reply to this message
Autor: Eric Voskuil
Data:  
Dla: 'William Swanson'
CC: libbitcoin
Temat: Re: [Libbitcoin] Library Update
Thanks for the feedback William, it was kinda quiet. I was wondering if the mail didn't go out :).

WRT _/- I'm happy to make the change, I don't have a preference. Amir selected the convention based on a desire to model the boost naming conventions. I suspect the reason them use the underscore vs. the hyphen is that the hyphen is not a valid character in C++. As a result file names cannot match class names (etc.) and it can make searching and refactoring more difficult. I ran into this in the SX rework as the file names match the command names, which use hyphens, but the class names that map to files and commands must differ. I left the command and file names hyphenated because for the commandline it is certainly more conventional.

Since it was his call originally and he put it in the roadmap we should let Amir weigh in on it before changing.

e

-----Original Message-----
From: William Swanson [mailto:swansontec@gmail.com]
Sent: Sunday, September 07, 2014 11:31 PM
To: Eric Voskuil
Cc: libbitcoin@???
Subject: Re: [Libbitcoin] Library Update

This is great! It's nice to see things moving along.

However, I do have one minor complaint - those underscores are really
ugly! Nobody uses underscores in library names; they are always
dashes. Just look through the package archive of any Linux distro to
see what I mean:

pacman -Slq | grep "lib" | grep "-" | wc -l
550

pacman -Slq | grep "lib" | grep "_" | wc -l
11

Can we please be like a normal open-source project and use dashes? I
know the underscore thing comes from boost, but they are off in their
own little world on this one. We don't need to copy their
idiosyncrasy.

Other than this one little aesthetic niggle, everything else is looking good!

-William