The flip side is that copying that uint256.h means bug for bug
compatibility, less work and less maintenance cost.

On 13/05/14 11:56, Amir Taaki wrote:
> We could also do that.
>
> Here are some unit tests we could copy:
>
> https://github.com/bitcoin/bitcoin/blob/master/src/test/uint256_tests.cpp
>
> On 13/05/14 11:50, Eric Voskuil wrote:
>> Why not use GMP (which we already have as a dependency via secp256k1)?
>>
>> e
>>
>> On 05/13/2014 02:19 AM, Amir Taaki wrote:
>>> We want to replace the remaining usage of big_number which is used in a
>>> few places for calculating work (comparisons, basic arithmetic).
>>>
>>> I'm thinking to copy uint256.h over from bitcoind:
>>>
>>> https://github.com/bitcoin/bitcoin/blob/master/src/uint256.h
>>>
>>> to include/bitcoin/utility/external/
>>>
>>> and then make a custom wrapper in include/bitcoin/utility/
>>> which implements a subset of that class which we require.
>>>
>>> Probably called 'hash_number' which is a descriptive name of this class.
>>> Another possibility is pow_number (pow = proof of work, not prisoner...)
>>> Or even proof_of_work_number?
>>>
>>> #include <bitcoin/utility/hash_number.hpp>
>>>
>>> Then after it's a few small steps to remove elliptic_curve_key,
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Libbitcoin mailing list
>>> Libbitcoin@???
>>> https://mailinglists.dyne.org/cgi-bin/mailman/listinfo/libbitcoin
>>>
>>
>
>
>
> _______________________________________________
> Libbitcoin mailing list
> Libbitcoin@???
> https://mailinglists.dyne.org/cgi-bin/mailman/listinfo/libbitcoin
>