:: Re: [Libbitcoin] [PATCH] Implement …
Page principale
Supprimer ce message
Répondre à ce message
Auteur: William Swanson
Date:  
À: Amir Taaki
CC: libbitcoin
Sujet: Re: [Libbitcoin] [PATCH] Implement a bitcoin URI parser
On Tue, Mar 11, 2014 at 6:55 AM, William Swanson <swansontec@???> wrote:
> The only thing I am waiting for is for the bitcoin people to accept my
> patches to BIP 21. The BIP had a number of ambiguities which made it
> impossible to write a correct parser, so I went ahead and tightened up
> their grammar. It is possible that they don't like my changes, and
> would rather fix the BIP in a different way (not allowing blank query
> parameters, or such). Once the BIP is stabilized, we will know if my
> code is correct or not.


Now that the Bitcoin core developers have accepted my changes to BIP
21, I have gone ahead and pushed my bitcoin URI parser into
libwallet's spesmilo:master. Feel free to make those cleanups you were
talking about, Amir.

I have also included a second commit, "Accept URI's with illegal
spaces", which might be a bit controversial. Basically, a lot of
bitcoin software in the wild is forgetting to escape query parameter
strings. Since spaces are the most common character to cause problems,
the patch simply accepts them rather than returning an error (as it
should). I am open to other ideas about how to provide a good user
experience in the face of these buggy URI's.

-William Swanson