Autore: Dan Dennedy Data: To: Minimalistic plugin API for video effects Oggetto: Re: [Frei0r] autoconf build problems and switch to cmake only
On Wed, Oct 17, 2012 at 4:00 PM, Dan Dennedy <dan@???> wrote: > On Wed, Oct 17, 2012 at 3:33 PM, Jaromil <jaromil@???> wrote:
>> On Thu, 11 Oct 2012, Dan Dennedy wrote:
>>
>>> On Fri, Sep 28, 2012 at 10:08 AM, Dan Dennedy <dan@???> wrote:
>>> > On Fri, Sep 28, 2012 at 2:05 AM, Jaromil <jaromil@???> wrote:
>>> >>
>>> >> re all
>>> >>
>>> >> while testing Janne's new filters I was also trying to add them into the
>>> >> autoconf build, but while doing so I'm realizing that our autoconf
>>> >> setup does not work to add filters and in fact skips already many of
>>> >> them.
>>>
>>> I know I OK'ed this, but the autotools build is actually very easy to
>>> maintain; it's all in src/Makefile.am. See my recent commit. And it
>>> is probably skipping plugins for you because you did not run
>>> autoreconf in some time. I have been trying to keep the autoconf build
>>> up-to-date. It is current AFAIK.
>>
>> OK to keep both then, I see you are updating it. thanks
>>
>> Meanwhile I've committed some small changes to build using cmake on OSX
>
> I have some problems with your changes for OS X. You are forcing the
> use of clang over gcc and thereby disabling some plugins that do not
> compile with clang. I am still building with gcc because it still
> works fine and because I am using test_pat in Shotcut. Also, you are
> forcing an (Intel) universal build, and on macports the architecture
> is chosen automatically or by the user at install/build time.
I overlooked for a moment that both of those builds (shotcut and
macports) are still using autotools. So, as long as we keep it as you
agreed then I don't have a major problem with it.